Mark generated constructors as #[inline] - #258
Merged
Merged
Conversation
The into_inner method is already inlined, but new, try_new and new_unchecked were not, so they could not be inlined across crate boundaries. Mark them the same way. Closes greyblake#237.
Owner
|
Thanks! |
Owner
|
Released in nutype-0.8.0-beta.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #237.
into_inneralready gets#[inline], butnew,try_newandnew_uncheckeddidn't, so they couldn't be inlined across crate boundaries (which is exactly the workspace case from that issue). This marks all three the same way.I added a few unit tests that render the generated code and assert the attribute is present.